WIP - upgrade to webpack 5 #11326
WIP - upgrade to webpack 5 #11326
Conversation
ndelangen
requested review from
alexandrebodin,
alterx,
igor-dv,
kazupon,
leonrodenburg,
thani-sh,
renaudtertrais,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
@ndelangen I will have a few commits to add to this PR to clean things related to Yarn PnP so can you ping me when you think it will be ok for me to do these changes? |
|
Is there any way I can help to speed up this merge? We've migrated to Webpack 5 and only thing that is not migrated is Storybook... |
|
@kirill-konshin Don't hold your breath. We're in RC for 6.0 and will re-evaluate this in August after that ships. Since this is a breaking change, the earliest we can merge release as is would be 7.0. However, to support early webpack5 users like yourself and support the evolution of webpack, we could potentially publish an OFFICIAL storybook fork. If you have thoughts on how that could work, that might help us push this along after 6.0 is out. |
|
@shilman thank you for clarification. I'd be happy to be among first adopters, alpha/beta does not matter. Probably a dedicated |
|
We'd be very welcoming to any help you could offer us @kirill-konshin 🙇 |
Roll back to Webpack 4 because Storybook does not support Webpack 5 for the near future (see storybookjs/storybook#11326 (comment)). Use @storybook/react (which includes React as a dependency) instead of Preact because the Storybook build breaks when using theme-ui (most likely because of the bundled React dependency).
So is there a dist tag that I can take and try? I only see How can I install this branch into my project? |
|
@shilman wrote:
Unfortunately |
|
@kirill-konshin we typically develop INSIDE the monorepo. once there's something usable, i'd be happy to figure out a way to publish it on some special dist tag so you can dogfood it in your org. |
|
@shilman sure, but I thought it's already in "shippable" state :) |
|
This branch is not in a shippable state. |
|
Antibot. |
|
Hi @kirill-konshin, |
|
@dudiharush I've put it on hold due to too many errors. I've updated things here and there and got more and more errors, so I just stopped at some point. |
|
Ok, thanks. |
Issue: #9216